Skip to content

fix(sarif): guard optional chain in baseline.test.ts for Biome 2.5.3 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theagenticguy merged 2 commits into from
Jul 9, 2026
Merged

fix(sarif): guard optional chain in baseline.test.ts for Biome 2.5.3 #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733d763
fix(sarif): guard optional chain in baseline.test.ts for Biome 2.5.3
theagenticguy Jul 9, 2026
0c2bc33
Merge branch 'main' into fix/sarif-unsafe-optional-chaining
theagenticguy Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sarif/src/baseline.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ test("diffSarif: same fingerprint, changed message → updated", () => {

const tagged = applyBaselineState(current, baseline);
const state = (tagged.runs[0]?.results?.[0] as unknown as { baselineState?: string })
.baselineState;
?.baselineState;
assert.equal(state, "updated");
});

Expand Down Expand Up @@ -172,7 +172,7 @@ test("diffSarif: git-mv rename — rename chain resolves URI-only changes to unc

const tagged = applyBaselineState(current, baseline, { renameChainFor });
const state = (tagged.runs[0]?.results?.[0] as unknown as { baselineState?: string })
.baselineState;
?.baselineState;
assert.equal(state, "unchanged");
});

Expand Down
Loading