Add backoff start for CAN#2913
Open
Sushisource wants to merge 1 commit into
Open
Conversation
maciejdudko
requested changes
Jun 12, 2026
| initialVersioningBehavior); | ||
| } | ||
|
|
||
| public ContinueAsNewOptions( |
Contributor
There was a problem hiding this comment.
I consider it a mistake that the original constructor is public; it should be deprecated with a comment directing users to use the builder, and the new constructor should be made private.
Comment on lines
27
to
+40
| public class SyncWorkflowContextTest { | ||
| SyncWorkflowContext context; | ||
| ReplayWorkflowContext mockReplayWorkflowContext = mock(ReplayWorkflowContext.class); | ||
| ExecutorService threadPool; | ||
| DeterministicRunner runner; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| this.threadPool = Executors.newCachedThreadPool(); | ||
| this.context = DummySyncWorkflowContext.newDummySyncWorkflowContext(); | ||
| this.context.setReplayContext(mockReplayWorkflowContext); | ||
| when(mockReplayWorkflowContext.getWorkflowType()) | ||
| .thenReturn(WorkflowType.newBuilder().setName("dummy-workflow").build()); | ||
| } |
Contributor
There was a problem hiding this comment.
threadPool, runner and the call to when should be moved inside the test that uses them.
Comment on lines
+60
to
+61
| @Test | ||
| public void testContinueAsNewBackoffStartInterval() { |
Contributor
There was a problem hiding this comment.
Nit: this test should be moved down as to not split up the two upsert SA tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
See title
Why?
Expose supported features on backend
Checklist
Closes
How was this tested:
Simple unit test
Any docs updates needed?