fix: options field should be optional in all components#3520
Merged
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
A recent change where we replaced the manual CRDs with OpenAPI generated CRDs made options field mandatory for components. Historically this field is optional and was never enforced in CRD but openAPI generated CRDs made this field mandatory as there no '+optional' Directive on this field. This PR adds the '+optional directive on this field so generated CRDs keep this field optional.
pramodbindal
force-pushed
the
SRVKP-12484
branch
from
20b3740 to
1707e5f
Compare
tekton-robot
added
size/M
vdemeester
approved these changes
Jun 22, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Member
|
/lgtm |
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A recent change where we replaced the manual CRDs with OpenAPI generated CRDs made options field mandatory for components.
Historically this field is optional and was never enforced in CRD but openAPI generated CRDs made this field mandatory as there no '+optional' Directive on this field.
This PR adds the '+optional directive on this field so generated CRDs keep this field optional.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes