Add --log-failed flag to pipelinerun logs command#2920
Open
chmouel wants to merge 1 commit into
Open
Conversation
tekton-robot
added
the
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
Add a --log-failed flag to `tkn pipelinerun logs` that filters output to only show logs from failed TaskRuns, similar to how GitHub Actions shows failed job logs. When --log-failed is set and the PipelineRun is still running, the completed-logs path is used so only TaskRuns that have already failed are shown. If no TaskRuns have failed, an informative error is returned. The flag composes with --task (intersection of both filters). Signed-off-by: Chmouel Boudjnah <chmouel@chmouel.com> Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
force-pushed
the
add-log-failed-flag
branch
from
645e0bb to
ff3075b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a
--log-failedflag totkn pipelinerun logsthat filters outputto only show logs from failed TaskRuns, similar to how GitHub CLI (gh) shows failed job logs. see https://docs.github.com/en/actions/how-tos/monitor-workflows/use-workflow-run-logs#viewing-logs-with-github-cli
Behavior
--log-failedis set, only TaskRuns withConditionFalsestatus are shown--log-failedis set and the PipelineRun is still running, the completed-logs path is used (skips--follow) so only already-failed TaskRuns appear--taskflag (intersection of both filters)Submitter Checklist