[feat/MAT-924] DrawingCanvas onStrokeStart prop 추가#365
Draft
b0nsu wants to merge 1 commit into
Draft
Conversation
펜툴바 자동 collapse trigger. stylus/마우스로 stroke 시작 시 호출되고 textMode 에선 fire 안 됨. PR #321 (MAT-585) 의 follow-up 으로 명시된 작업 — 패키지로 옮긴 6줄. - Props 에 optional onStrokeStart 추가 - pan.onBegin worklet 안 stylus/mouse 통과 + textMode 분기 후 runOnJS 호출 - useMemo deps 에 onStrokeStart 포함 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
펜툴바 자동 collapse trigger 용 `onStrokeStart` callback prop 추가. PR #321 (MAT-585) 본문에 명시된 follow-up — scrap/utils/skia/drawing.tsx 의 6줄을 새 패키지 `@repo/pointer-native-drawing` 으로 옮김.
Linear
Changes
Testing
Risk / Impact