Skip to content

morph: fix INDEX_RANK to be a string #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcristau merged 1 commit into from
Jul 3, 2026
Merged

morph: fix INDEX_RANK to be a string #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/taskgraph/morph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ def make_index_task(parent_task, taskgraph, label_to_taskid, parameters, graph_c
task.task["payload"]["command"] = ["insert-indexes.js"] + index_paths
task.task["payload"]["env"] = {
"TARGET_TASKID": parent_task.task_id,
"INDEX_RANK": parent_task.task.get("extra", {}).get("index", {}).get("rank", 0),
"INDEX_RANK": str(
parent_task.task.get("extra", {}).get("index", {}).get("rank", 0)
),
}
return task, taskgraph, label_to_taskid

Expand Down
2 changes: 1 addition & 1 deletion test/test_morph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def test_make_index_tasks(make_taskgraph, graph_config):

assert index_task.task["payload"]["command"][0] == "insert-indexes.js"
assert index_task.task["payload"]["env"]["TARGET_TASKID"] == "a-tid"
assert index_task.task["payload"]["env"]["INDEX_RANK"] == 1540722354
assert index_task.task["payload"]["env"]["INDEX_RANK"] == "1540722354"

# check the scope summary
assert index_task.task["scopes"] == ["index:insert-task:gecko.v2.mozilla-central.*"]
Expand Down