Read relation blocks without multipolygons#905
Open
Symmetricity wants to merge 1 commit into
Open
Conversation
ReadRelations skipped an entire primitive block unless the block string table contained both type and multipolygon. That prevented otherwise valid boundary or custom relation_function processing when a block had no multipolygon string. Keep the existing per-relation filtering, but enter the relation loop whenever the block contains a type key. relationIsType already handles a missing multipolygon value by returning false. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is AI generated.
Summary
table does not contain
"multipolygon"Background
ReadRelations()skipped an entire relation primitive block unless the blockstring table contained both
"type"and"multipolygon":That means a valid block containing boundaries or custom relations, but no
literal
"multipolygon"string, never reached the existing relation loop.The later per-relation logic already handles non-multipolygon relations:
relationIsType()returnsfalsewhen a value key is missingoutput.canWriteRelations()I checked the history around relation processing. The guard appears to have
come from the older multipolygon-only path and survived later relation support;
I did not find a rationale for skipping whole blocks solely because the
"multipolygon"string is absent.Change
Enter the relation loop whenever the block has a
"type"key. Leave theexisting per-relation checks to decide whether each relation is a multipolygon,
boundary, custom writable relation, or should be skipped.
Expected Behavior
Profiles that only need multipolygons should behave the same. Profiles that
write or scan other relation types can now see valid relation blocks that were
previously skipped when
"multipolygon"was absent from the block string table.The change may process more relation blocks for profiles that enable custom
relation writing, but those blocks were already intended to be considered by
the later filtering logic.
Testing
git diff --checkctest --output-on-failure(no CMake tests are registered in this repo)