Skip to content

Add legacy RN close recovery sweep#92

Open
ben-kaufman wants to merge 5 commits into
masterfrom
codex/legacy-rn-close-recovery
Open

Add legacy RN close recovery sweep#92
ben-kaufman wants to merge 5 commits into
masterfrom
codex/legacy-rn-close-recovery

Conversation

@ben-kaufman
Copy link
Copy Markdown
Collaborator

Summary

Adds a targeted recovery path for legacy React Native Bitkit wallets whose Blocktank cooperative-close outputs landed in native SegWit scripts derived from the selected legacy/wrapped address key paths.

What changed

  • Added core scan and prepare-sweep APIs for the legacy RN native-segwit recovery flow.
  • Scans the affected selected-address purposes as P2WPKH and prepares a signed sweep transaction to a caller-provided destination.
  • Reuses the existing raw transaction broadcast API rather than adding a separate broadcast path.
  • Added regression tests covering the affected derivation, signed sweep construction, and explicit zero-fee handling.
  • Bumped bitkit-core to 0.1.63 and regenerated iOS/Android bindings.

Validation

  • ./build.sh ios
  • ./build.sh android
  • cargo fmt
  • git diff --check
  • cargo test legacy_rn --lib
  • cargo test sweep --lib

Also verified this branch is based on latest origin/master (8e49ab8) and that v0.1.63 was not already present on the remote before the bump.

@ben-kaufman ben-kaufman marked this pull request as ready for review May 27, 2026 16:27
@ben-kaufman ben-kaufman requested a review from ovitrif May 27, 2026 16:27
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5177cf98e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant