Do not abort the whole install when importmap:require fails - #1097
Open
Amoifr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1015.
When
PackageJsonSynchronizersynchronizes AssetMapper packages, it runsimportmap:require, which reaches out to the network (the jsDelivr API). If that call fails (a rate limit, or just bad connectivity, as @nicolas-grekas hit during a workshop), theScriptExecutionExceptionpropagates and aborts the wholecomposer require, leaving the app half configured with no obvious way for a newcomer to recover.This makes that step fail safe: a failing
importmap:requireno longer aborts the install. The entries that could not be added are collected and reported at the end, with a hint to runcomposer installagain once the network is back (the synchronization re-runs on every install and retries the missing entries).Before:
After the recipes are still applied, and you get:
This is the smaller, incremental fix. @nicolas-grekas, you mentioned you'd rather have
PackageJsonSynchronizernot touch the network at all and defer it to a later stage (e.g.cache:clear). That is a larger change, happy to look into it separately if you'd prefer that direction instead.Thanks!