Skip to content

[codex] Clarify OneSignal user ID attribute #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anglinb wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

[codex] Clarify OneSignal user ID attribute #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8547904
Add Singular integration attribute
anglinb Jun 26, 2026
3a80a90
Update changelog for Singular integration attribute
anglinb Jun 26, 2026
40c179b
Merge pull request #418 from superwall/codex/singular-sdid-attribute
anglinb Jun 26, 2026
9c1f0f8
Clarify OneSignal user ID attribute
anglinb Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

The changelog for `Superwall`. Also see the [releases](https://github.com/superwall/Superwall-Android/releases) on GitHub.

## 2.7.18

## Enhancements

- Adds `singularDeviceId` as an `AttributionProvider`.
- Clarifies that `AttributionProvider.ONESIGNAL_ID` should be set to the OneSignal User ID used by the OneSignal integration.

## 2.7.17

## Fixes
Expand Down
8 changes: 6 additions & 2 deletions ...droidTest/java/com/superwall/sdk/models/attribution/AttributionProviderIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ class AttributionProviderIntegrationTest {
AttributionProvider.MIXPANEL to "mp_distinct_789",
AttributionProvider.GOOGLE_ADS to "gclid_abc123",
AttributionProvider.ADJUST_ID to "adjust_123",
AttributionProvider.SINGULAR_DEVICE_ID to "singular_device_123",
AttributionProvider.AMPLITUDE_DEVICE_ID to "amp_device_456",
AttributionProvider.FIREBASE_APP_INSTANCE_ID to "firebase_789",
AttributionProvider.CUSTOM to "custom_id_xyz",
Expand All @@ -93,10 +94,11 @@ class AttributionProviderIntegrationTest {
assertEquals("mp_distinct_789", attributionProps["mixpanel"])
assertEquals("gclid_abc123", attributionProps["googleAds"])
assertEquals("adjust_123", attributionProps["adjustId"])
assertEquals("singular_device_123", attributionProps["singularDeviceId"])
assertEquals("amp_device_456", attributionProps["amplitudeDeviceId"])
assertEquals("firebase_789", attributionProps["firebaseAppInstanceId"])
assertEquals("custom_id_xyz", attributionProps["custom"])
assertEquals(8, attributionProps.size)
assertEquals(9, attributionProps.size)
}
}
}
Expand Down Expand Up @@ -156,6 +158,7 @@ class AttributionProviderIntegrationTest {
val attributionIdentifiers =
mapOf(
AttributionProvider.ADJUST_ID to "adjust_test_123",
AttributionProvider.SINGULAR_DEVICE_ID to "singular_device_test_123",
AttributionProvider.AMPLITUDE_DEVICE_ID to "amp_device_test_456",
AttributionProvider.AMPLITUDE_USER_ID to "amp_user_test_789",
AttributionProvider.APPSFLYER_ID to "appsflyer_test_abc",
Expand Down Expand Up @@ -185,6 +188,7 @@ class AttributionProviderIntegrationTest {
val attributionProps = attributionManager.integrationAttributes

assertEquals("adjust_test_123", attributionProps["adjustId"])
assertEquals("singular_device_test_123", attributionProps["singularDeviceId"])
assertEquals("amp_device_test_456", attributionProps["amplitudeDeviceId"])
assertEquals("amp_user_test_789", attributionProps["amplitudeUserId"])
assertEquals("appsflyer_test_abc", attributionProps["appsflyerId"])
Expand All @@ -204,7 +208,7 @@ class AttributionProviderIntegrationTest {
assertEquals("tenjin_test_def", attributionProps["tenjinId"])
assertEquals("posthog_test_ghi", attributionProps["posthogUserId"])
assertEquals("customerio_test_jkl", attributionProps["customerioId"])
assertEquals(20, attributionProps.size)
assertEquals(21, attributionProps.size)
}
}
}
Expand Down
6 changes: 5 additions & 1 deletion superwall/src/main/java/com/superwall/sdk/models/attribution/AttributionProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ enum class AttributionProvider(
@SerialName("adjustId")
ADJUST_ID("adjustId"),

/** The Singular Device ID (SDID). */
@SerialName("singularDeviceId")
SINGULAR_DEVICE_ID("singularDeviceId"),

/** The Amplitude device identifier. */
@SerialName("amplitudeDeviceId")
AMPLITUDE_DEVICE_ID("amplitudeDeviceId"),
Expand All @@ -35,7 +39,7 @@ enum class AttributionProvider(
@SerialName("brazeAliasLabel")
BRAZE_ALIAS_LABEL("brazeAliasLabel"),

/** The OneSignal Player identifier for the user. */
/** The OneSignal User ID (`onesignal_id`) for the user. */
@SerialName("onesignalId")
ONESIGNAL_ID("onesignalId"),

Expand Down
Loading