fix(framework): resolve vite/vitest from apps/framework, not repo root - #156
Merged
Conversation
project-runner.ts pointed ROOT three directories up (to the monorepo root) after the apps/framework move, so viteBuild/vitestRun looked for node_modules/vite and node_modules/vitest where they don't exist under pnpm's isolated layout, breaking every frontend eval scoring run (smoke-framework.ts's failure was silenced by its debug-gated console.error shim). Point ROOT at apps/framework and symlink its node_modules into the workspace so vite/vitest can resolve themselves and the eval fixture's deps (react, @vitejs/plugin-react, etc). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Rodriguespn
marked this pull request as ready for review
August 2, 2026 17:03
barryroodt
requested changes
Aug 3, 2026
barryroodt
left a comment
barryroodt
left a comment
Contributor
There was a problem hiding this comment.
Good catch, and this passes the framework smoke test locally.
One issue before merge: each workspace now keeps a node_modules symlink under results/, and upload-artifact follows symlinks, so every frontend eval artifact will carry the framework dependencies. Could you add !results/**/node_modules/** to the upload step?
upload-artifact dereferences symlinks, so the node_modules symlink that project-runner.ts now drops into each workspace under results/ would get copied into every frontend eval's artifact. Addresses review feedback on PR #156. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
barryroodt
approved these changes
Aug 3, 2026
barryroodt
added a commit
that referenced
this pull request
Aug 3, 2026
…ests-into-per-scorer-vitest-files Conflict in apps/framework/harness/project-runner.ts: #156 and this branch fix the same root cause (vite/vitest resolution) different ways. #156 keeps the toolchain in apps/framework and symlinks its node_modules into the workspace. This branch moves the toolchain to the root manifest so the workspace under results/ resolves by walking up, which is the contract copyToHost already documents. Kept this branch's resolvePackageBin, dropped linkNodeModules: after the merge apps/framework/node_modules/vite no longer exists, so #156's path would throw the very error it fixed. Kept #156's eval-refresh.yml artifact exclusion. Vite still writes node_modules/.vite into the workspace, so it is not vestigial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the lingering failed framework smoke test that was erroring because
project-runner.tslooked forvite/vitestin the monorepo root'snode_modulesinstead ofapps/framework's, where pnpm actually installs them.Note: no CI workflow runs
pnpm check/typecheck(onlybiome format:checkdoes), so this failure never surfaced in Actions — only locally, and silently, since the smoke script's error output is suppressed unless run with--debug.Repro on main:
Fails with
Cannot find module '.../node_modules/vite/bin/vite.js'.