perf: optimize zoom overlay component to reduce DOM queries#7401
Open
lavjeetrai wants to merge 1 commit into
Open
perf: optimize zoom overlay component to reduce DOM queries#7401lavjeetrai wants to merge 1 commit into
lavjeetrai wants to merge 1 commit into
Conversation
github-actions
Bot
added
performance
Contributor
|
🧪 Jest Test Results ✅ All Jest tests passed! This PR is ready to merge. Coverage: Statements: 46.9% | Branches: 38.37% | Functions: 51.3% | Lines: 47.33% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the zoom overlay component to reduce DOM queries and improve performance.
Because zooming typically fires many rapid events in succession, removing repetitive DOM querying, element creation, and CSS parsing significantly reduces overhead and prevents UI lag. The function now only updates the text percentage and opacity on subsequent calls.
Details:
js/utils/zoomOverlay.js): Refactored the overlay logic to cache the DOM element and timeout ID using module-scoped variables. This eliminates the need to calldocument.getElementByIdevery time the overlay updates, improving overall performance during zoom actions.Labels: