feat(session): add put_object_kwargs support to S3SessionManager#2328
Open
gauravSsinha wants to merge 1 commit into
Open
feat(session): add put_object_kwargs support to S3SessionManager#2328gauravSsinha wants to merge 1 commit into
gauravSsinha wants to merge 1 commit into
Conversation
Add support for passing custom parameters to S3 put_object calls in
S3SessionManager. This enables configuring server-side encryption
(SSE-KMS), storage class, tagging, and other S3 PutObject parameters
when storing session data.
The put_object_kwargs parameter is passed via **kwargs and stored as
an instance variable, then spread into all put_object calls. This
approach is backwards-compatible and follows the maintainer's
suggested pattern.
Example usage:
session_manager = S3SessionManager(
session_id='my-session',
bucket='my-bucket',
put_object_kwargs={
'ServerSideEncryption': 'aws:kms',
'SSEKMSKeyId': 'arn:aws:kms:us-east-1:123456789012:key/...'
}
)
Closes strands-agents#1247
Signed-off-by: Gaurav Kumar Sinha <gaurav@substrai.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for passing custom parameters to S3
put_objectcalls inS3SessionManager. This enables configuring server-side encryption (SSE-KMS), storage class, tagging, and other S3 PutObject parameters when storing session data.Changes
put_object_kwargsextraction from**kwargsinS3SessionManager.__init__()_write_s3_object()to spreadput_object_kwargsinto allput_objectcallsUsage
Design Decision
Following the maintainer's guidance in #1247,
put_object_kwargsis passed via**kwargsand stored as an instance variable. This approach:**kwargsalready accepted)Testing
put_object_kwargsCloses #1247