Deprecate PHP Version: Fix .puprc parse check in info command#49
Merged
Conversation
The info command was passing the filename string '.puprc' to json_decode() instead of reading the file contents first, causing it to always report a parse error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cast file_get_contents() return to string to satisfy PHPStan level 8, since it returns string|false. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claudiosanches
approved these changes
Feb 12, 2026
jonwaldstein
changed the base branch from
base/ENG-222/deprecate-php-version
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 ENG-222
Summary
pup infowhere the.puprcparse check was passing the filename string'.puprc'tojson_decode()instead of reading the file contents first, causing it to always report a parse error even for valid.puprcfiles.Discovered while working on the TypeScript rewrite of the info command in #36.
Test plan
pup infoin a project with a valid.puprcfile — should show ✅.puprc - existspup infoin a project with an invalid.puprcfile (e.g. malformed JSON) — should show ❌.puprc - exists but could not be parsed: <error message>pup infoin a project with no.puprcfile — should show ⚫.puprc - does not exist