Fix connection load#60
Open
JoukoVirtanen wants to merge 7 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Molter73
reviewed
Jun 5, 2026
Contributor
Molter73
left a comment
Molter73
left a comment
There was a problem hiding this comment.
Changes look good overall, but there are a few comments that I would like addressed.
Co-authored-by: Mauro Ezequiel Moltrasio <moltrasiom@hotmail.com>
JoukoVirtanen
force-pushed
the
jv-fix-connection-load
branch
from
d898af9 to
063b439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the connection load pods would sometimes crash. There are two fixes here. The first is a sleep between starting the server and client in the
init.shscript, to reduce the chances of a race condition leading to a crash. The second is that if connection load attempts to use a port already in use it sleeps for 1 second before retrying, instead of immediately crashing. It retries up to 30 times. This will be especially useful when berserker has multiple workers at the same time opening and closing ports.