Fix memory leak#59
Conversation
| let semaphore = Arc::new(( | ||
| std::sync::Mutex::new(0usize), | ||
| std::sync::Condvar::new(), | ||
| )); |
There was a problem hiding this comment.
[ultra-nit] We might want to put this in a new type and add something like .inc and .dec methods to remove some verbosity in the loop. But honestly, this way is fine as well.
Co-authored-by: Mauro Ezequiel Moltrasio <moltrasiom@hotmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Currently threads created in
run_payloadare not closed resulting in a memory leak. This PR fixes that.This PR also fixes a memory leak resulting from
CString::new(format!("{base}/{uniq}")).unwrap().into_raw().