Fix validator issues#4142
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses configuration validation and related UI rendering behavior by adding validator-focused test coverage and refining how the web UI decides whether to treat dotted strings as Home Assistant entity IDs.
Changes:
- Update
render_type()in the web UI to avoid attempting HA entity resolution for plain string schema fields that happen to contain dots (e.g., hostnames). - Add a comprehensive
validate_config()test suite covering APPS_SCHEMA type validation cases. - Register the new validator test in the unit test runner.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/web.py | Adjusts entity-resolution logic for dotted strings during config rendering. |
| apps/predbat/unit_test.py | Registers the new APPS_SCHEMA validator test in the test runner. |
| apps/predbat/tests/test_validate_config.py | Adds validator test coverage for APPS_SCHEMA types and sensor-type behaviors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.