[draft] use mini_portile mkmf_config(static:) to simplify extconf#2977
Open
flavorjones wants to merge 2 commits into
Open
[draft] use mini_portile mkmf_config(static:) to simplify extconf#2977flavorjones wants to merge 2 commits into
flavorjones wants to merge 2 commits into
Conversation
flavorjones
force-pushed
the
flavorjones-mini_portile-2.9
branch
from
f9c5ec0 to
b9ff0ff
Compare
flavorjones
changed the title
Member
Author
|
Welp, the BSD build is actually a legit failure -- looks like it's dynamically linking the system shared libxml2 library rather than statically linking the packaged libxml2 library. Need to investigate what's going on there. |
Member
Author
|
Update: I've reproduced the FreeBSD failure using system ruby on freebsd 13.2, but it doesn't reproduce if I use a ruby installed via rbenv/ruby-build. |
Member
Author
|
OK, reproduced with a system ruby on an Ubuntu image: https://github.com/sparklemotion/nokogiri/actions/runs/6209371364/job/16856521387?pr=2977 |
flavorjones
force-pushed
the
flavorjones-mini_portile-2.9
branch
from
1c9c63a to
bda808f
Compare
flavorjones
changed the title
flavorjones
force-pushed
the
flavorjones-mini_portile-2.9
branch
from
bda808f to
0e33770
Compare
2 tasks
flavorjones
force-pushed
the
flavorjones-mini_portile-2.9
branch
2 times, most recently
from
8c3672b to
d15d1af
Compare
flavorjones
force-pushed
the
flavorjones-mini_portile-2.9
branch
from
d15d1af to
82336ec
Compare
flavorjones
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Simplifying the extconf by using the new
mkmf_configfeature in mini_portile 2.8.5Have you included adequate test coverage?
Existing test coverage is sufficient to ensure nothing's broken
Does this change affect the behavior of either the C or the Java implementations?
N/A