fix(data-connections): target GCS, align DataProvider with storage_type

[alukach]

Problem

Creating a GCP data connection persisted details.provider: "gcp", but the backend (data.source.coop) addresses Google Cloud Storage as "gcs". The same latent mismatch existed for Azure ("az" vs "azure").

Root cause: DataProvider (connection config) and ProductMirror.storage_type (a per-mirror field) were two vocabularies bridged by a hand-written STORAGE_TYPE_BY_PROVIDER map duplicated in products.ts and product-mirrors.ts.

Changes

1. Align DataProvider values to the backend vocabulary

enum DataProvider { S3 = "s3", Azure = "azure" /* was "az" */, GCS = "gcs" /* was GCP="gcp" */ }

Both translation maps deleted. Member GCP→GCS, schema/type Gcp*→Gcs*. Auth type stays gcp_workload_identity (WIF is a GCP-platform feature, not storage). Form label → "Google Cloud Storage".

2. Remove ProductMirror.storage_type entirely

Nothing branched on it — the proxy keys off details.provider, and the only source.coop consumer was a display label. It was a denormalized copy of the provider. Dropped the field; the mirror "Type" label now derives from the connection's provider. This dissolves the "two vocabularies" problem rather than just aligning it, and removes both provider→storage_type casts.

3. Migration (legacy az/gcp connection rows)

DynamoDB reads bypass Zod, so normalizeConnection in the data-connections client remaps "az"→"azure" / "gcp"→"gcs" on fetchById/listAll. Marked ponytail: — drop after backfill. Removing storage_type needs no migration: ProductMirrorSchema is a plain z.object, so old records still carrying the field parse fine (unknown key stripped).

Backend compatibility (verified against data.source.coop)

• S3 unchanged. Azure accepts both "az" and "azure" → compatible during rollout. GCS: old "gcp" never worked (hit the error arm); "gcs" is accepted. So this is the fix, not a regression.
• ⚠️ Separate prerequisite for GCS to actually connect: the data proxy must enable the multistore gcp cargo feature — and that currently fails to compile for wasm32-unknown-unknown (object_store's GCS credential signing uses ring::SystemRandom, unsupported on that target). Tracked separately; not in this PR.

Verification

tsc --noEmit clean · jest affected suites 116/116 · lint clean on changed files.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
source-cooperative	Ready	Preview, Comment	Jul 22, 2026 5:41pm

[claude]

Claude finished @alukach's task in 1m 34s —— View job

---

Claude's review

• Gather context (PR body, changed files list)
• Review diff for correctness bugs, security issues, best-practice problems
• Post findings

---

✅ No blocking issues — safe to merge.

• The DataProvider rename ("az"→"azure", "gcp"→"gcs") is applied consistently across the codebase — no stray references to DataProvider.GCP, "gcp", or "az" remain outside the legacy-shim map (src/lib/clients/database/data-connections.ts:20-23) and its own doc comment.
• normalizeConnection (src/lib/clients/database/data-connections.ts:25-30) is correctly wired into both fetchById and listAll, the only two raw-DynamoDB read paths for connections, and is well covered by data-connections.test.ts. update() doesn't need the shim since it always writes back a full canonical details object supplied by the caller.
• ProductMirrorsManager.tsx:236-240 swaps mirror.storage_type for connectionInfo[...].provider — consistent with storage_type being fully dropped from ProductMirrorSchema (src/types/product.ts). If a mirror's underlying connection was deleted, connectionInfo[...] is undefined and "Type" renders blank, matching the existing degrade-gracefully pattern already used for "Bucket" on the same line — not a regression.
• src/components/features/products/object-browser/ObjectSummary.tsx:31 correctly updates the literal comparison from "az" to "azure"; no branch exists for GCS there, but that gap pre-dates this PR (there was no "gcp" branch either) and is out of scope.
• Schema/type renames (GcpDataConnectionSchema→GcsDataConnectionSchema, GcpDataConnection→GcsDataConnection) and their OpenAPI tags are consistent; gcp_workload_identity auth type name is correctly left unchanged since it names a GCP platform feature, not the storage backend.
• Test updates align with the source changes (legacy-shim tests, dropped storage_type assertions, renamed GCS test cases).

[alukach]

Split into two focused PRs:

• fix(data-connections): target GCS, align DataProvider with storage_type #453 — fix(data-connections): target GCS, align DataProvider values
• refactor(mirrors): drop denormalized ProductMirror.storage_type #454 — refactor(mirrors): drop denormalized ProductMirror.storage_type (stacked on fix(data-connections): target GCS, align DataProvider with storage_type #453)

Closing this combined PR in favor of those.