fix: handleKeyDown type cast, Terraform locking, sensitive outputs, password validation#1024
Open
Mozez155 wants to merge 4 commits into
Open
fix: handleKeyDown type cast, Terraform locking, sensitive outputs, password validation#1024Mozez155 wants to merge 4 commits into
Mozez155 wants to merge 4 commits into
Conversation
Replace the incorrect `as unknown as React.FormEvent` cast with a properly typed `React.KeyboardEvent<HTMLFormElement>` handler that calls `e.currentTarget.requestSubmit()` to trigger native form submission without unsafe coercion. Add unit tests covering Enter submission, validation on empty input, and non-Enter key no-op. closes solutions-plug#952
Pass the environment-specific backend HCL file to `terraform init` so the DynamoDB table declared in each backend config is actually activated. Add `-lock=true -lock-timeout=5m` to all plan and apply commands so concurrent runs fail instead of corrupting state. Add a `terraform validate` step (with a CI-only var file) that runs before every plan. closes solutions-plug#953
Add `sensitive = true` to the redis `endpoint` and `redis_url` outputs in the Redis module and to `redis_endpoint` in the root outputs file, preventing these values from appearing in plaintext in CI logs and `terraform output` calls. closes solutions-plug#954
Raise `db_password` minimum length from 8 to 24 characters and add complexity requirements (uppercase, lowercase, digits, special chars). Add `redis_auth_token` variable with `sensitive = true` and the same complexity validation, preventing weak credentials from reaching production infrastructure. closes solutions-plug#955
|
@Mozez155 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as unknown as React.FormEventcast inLandingPage.handleKeyDownwith a properly typedReact.KeyboardEvent<HTMLFormElement>handler that callsrequestSubmit(); add unit tests covering Enter submission, validation on empty input, and non-Enter key no-op.terraform initso DynamoDB state locking is actually activated; add-lock=true -lock-timeout=5mto allterraform planandterraform applyCI steps; add aterraform validatestep before every plan.sensitive = trueto the Redisendpointandredis_urlmodule outputs and toredis_endpointin the rootoutputs.tf, preventing plaintext leakage in CI logs andterraform output.db_passwordminimum length from 8 → 24 characters and add complexity rules (upper, lower, digit, special); addredis_auth_tokenvariable withsensitive = trueand the same validation; add a CIterraform validatestep backed by a placeholder var file.Test plan
frontend/with no type errorsLandingPage.keyboard.test.tsxpasses (Enter submits, empty-email shows error, non-Enter is a no-op)terraform validate -var-file=environments/ci-validate.tfvarsexits 0terraform planin CI now passes-lock=true -lock-timeout=5mand uses the correct backend HCL per environmentterraform outputmasksredis_endpointas<sensitive>db_passwordorredis_auth_tokenshorter than 24 chars causesterraform validateto fail with the new error messagecloses #952
closes #953
closes #954
closes #955