Skip to content

Fix suffix computation#11

Merged
raphael-theriault-swi merged 1 commit into
mainfrom
NH-125543
Jun 17, 2026
Merged

Fix suffix computation#11
raphael-theriault-swi merged 1 commit into
mainfrom
NH-125543

Conversation

@raphael-theriault-swi

Copy link
Copy Markdown
Contributor

Because the empty string is a falsey value the suffix ended up being -main for main rather than empty

Copilot AI review requested due to automatic review settings June 16, 2026 20:40
@raphael-theriault-swi raphael-theriault-swi requested review from a team as code owners June 16, 2026 20:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the CI workflow’s SUFFIX computation so that main correctly results in an empty suffix (rather than -main) by avoiding the falsey-empty-string behavior in GitHub Actions expression short-circuit logic.

Changes:

  • Adjusted the GitHub Actions expression used to compute SUFFIX so main resolves to '' and non-main branches resolve to -<branch>.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@raphael-theriault-swi raphael-theriault-swi merged commit 34ee97d into main Jun 17, 2026
7 checks passed
@raphael-theriault-swi raphael-theriault-swi deleted the NH-125543 branch June 17, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants