Skip to content

Fix AdaptiveBeamForceFieldAndMass - #237

Merged
fredroy merged 4 commits into
sofa-framework:masterfrom
bakpaul:26_07_fix_adaptive_beam_ff_and_mass
Jul 30, 2026
Merged

Fix AdaptiveBeamForceFieldAndMass#237
fredroy merged 4 commits into
sofa-framework:masterfrom
bakpaul:26_07_fix_adaptive_beam_ff_and_mass

Conversation

@bakpaul

@bakpaul bakpaul commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

This component was broken wince the begining but it wasn't an issue until I needed to accumulate inertia terms on the RHS of the Integration scheme. The problem here is thazt the addMDx method ignores the dx passed and always uses the same value. This broke completely the dynamics, nullifying the contribution of the mass to the RHS.

It was identified by AI, and the code was made by AI, but it works properly now thank's to this.

@bakpaul bakpaul added pr: fix pr: clean pr: status to review To notify reviewers to review this pull-request pr: breaking labels Jul 21, 2026
@bakpaul

bakpaul commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

After some investigation, the regression here is indeed a consequence of the PR. Before my PR, because addMDx was broken, when adding the rayleigh damping to the RHS, only the part coming from the rayleigh stiffness was added. Indeed, when adding the part multiplied by M, the forcefield added M*g instead, which is 0 (because here g=0).

After trying to recreate the same behavior by removing the rayleigh stiffness from the RHS, the results are closer than the expected precision. So I'll regenerate the references to fix this regression.

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 30, 2026
@fredroy
fredroy merged commit 6077e3a into sofa-framework:master Jul 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking pr: clean pr: fix pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants