Add GraphQL v17 support#104
Merged
Merged
Conversation
ivome
marked this pull request as ready for review
July 23, 2026 01:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds GraphQL 17 support and simplifies hybrid CJS/ESM packaging by importing all graphql utilities from the package root.
Addresses #103
getVariableValues()returning{ variableValues }instead of{ coerced }, use string-literal ASTkindchecks (GraphQL 17 makesKindtype-only), and relax error-message assertions for GraphQL 17's more verbose argument errors.graphql/execution/valuesimport and allsed-based import rewriting in the hybrid-module scripts. Every graphql import now goes through the baregraphqlspecifier, which avoids mixing ESM/CJS copies of graphql in the same realm.peerDependencies.graphql:^16.6.0 || ^17.0.0(drops 15.x and 16.0–16.5;getVariableValues/getArgumentValuesbecame root exports in 16.6)~16.6,~16,~17.0; Node 20 removed from CI"DOM"totsconfig.jsonlibso GraphQL 17's type definitions compile under TypeScript 4.4 (forAbortSignal/AbortControllerreferences).Breaking changes
graphqlversion is now 16.6.0 (was 15.0.0).Test plan
yarn testpasses on graphql 16.6.0, 16.14.2, and 17.0.2 (CJS + ESM)@include(if: $show)with explicit variable values (covers variable → directive coercion across graphql versions)dist/artifacts contain only baregraphqlimports (no deep imports, no.mjs/.jsrewrites)dist/on graphql 17 (no realm crash)