-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/prd 1032 Token authentication #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adrian-situm
wants to merge
36
commits into
develop
Choose a base branch
from
feature/PRD-1032
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
80500b4
Automatic merge into master to Release 3.18.6
situmops f225669
Automatic merge into master to Release 3.18.7
situmops ac5c4d2
Automatic merge into master to Release 3.18.8
situmops d4bc9da
Automatic merge into master to Release 3.18.9
situmops 16c31d0
Automatic merge into master to Release 3.18.10
situmops 2be003f
Automatic merge into master to Release 3.18.11
situmops 857f3a6
Automatic merge into master to Release 3.18.12
situmops c6e5312
Merge pull request #609 from situmtech/release/3.18.13
SilviaMRegueira 3411ec5
Automatic merge into master to Release 3.18.14
situmops 2a96744
Automatic merge into master to Release 3.18.15
situmops 2c0b5fe
Automatic merge into master to Release 3.18.16
situmops 8e89e32
Automatic merge into master to Release 3.18.17
situmops aab7c2a
Automatic merge into master to Release 3.18.18
situmops f246476
Automatic merge into master to Release 3.18.19
situmops 9e6a2e7
Automatic merge into master to Release 3.18.20
situmops 544777c
Automatic merge into master to Release 3.18.21
situmops f3b291c
Automatic merge into master to Release 3.18.22
situmops e039e40
Automatic merge into master to Release 3.18.23
situmops 6cf0c7b
Automatic merge into master to Release 3.18.24
situmops bb9dfd1
Automatic merge into master to Release 3.18.25
situmops c1c6c03
Merge pull request #637 from situmtech/release/3.18.25
SilviaMRegueira f5456f5
Automatic merge into master to Release 3.18.26
situmops 6a6c501
Merge pull request #642 from situmtech/release/3.18.26
SilviaMRegueira b2c30cc
Added support for token authentication
adrian-situm f849990
Updated react native version
adrian-situm 499e817
Added native implementation for setToken
adrian-situm 22ec8b6
Fixed the auth being sent to the viewer when loading it with an apike…
adrian-situm fd61126
MapView now reloads when changing the apikey
adrian-situm 0e18307
Cleaned some logic
adrian-situm ccab37f
Added comments and cleaned old logic
adrian-situm 021f572
Updated changelog
adrian-situm ca185cb
Small refactors
adrian-situm cf94bc3
Refactors and logic changes to SitumProvider
adrian-situm 11f885e
Small adjustments
adrian-situm e78e8b0
Simplified logic in SitumProvider and improved changelog
adrian-situm 98c92a3
Merge remote-tracking branch 'origin/develop' into feature/PRD-1032
adrian-situm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| ## Unreleased | ||
| ### Added | ||
|
|
||
| - Updated Android example app targetSdkVersion from 35 to 37 | ||
| - Added JWT token authentication support through `SitumPlugin.setToken()` and the new optional `SitumProvider.token` property. | ||
| - MapView authentication can now be updated at runtime when using JWT token authentication. | ||
|
cristian-situm marked this conversation as resolved.
|
||
| - The most recently updated credential becomes the active authentication method, regardless of whether it is added through a `SitumPlugin` method or via a `SitumProvider` prop. | ||
|
|
||
| ### Changed | ||
|
|
||
| - `SitumProvider.apiKey` is now optional. If no credentials are available when the MapView loads, it waits until authentication is provided. | ||
| - Updated the example application React Native from 0.79.1 to 0.83.10 to fix an issue that prevented the app from compiling on iOS. | ||
| - Updated Android example application targetSdkVersion from 35 to 37. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Que opcion va a tener preferencia en mi app si llamo a las 2 en mi codigo ? Entiendo que la ultima que hayas llamado ? Cual seria la opcion "ideal" o mas normal/idiomatica de usar la autenticacion por token ?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exacto, se aplica la última a la que hayas llamado. La forma ideal de usarlo es por medio del provider, pues se integra con el flujo de React.
Por otro lado, aclaro que en el provider he hecho que el token tenga prioridad sobre la apikey para evitar posibles errores si mandas los 2 a la vez. A esto tampoco creo que haya que darle muchas vueltas, al final no se deberían utilizar apikey y token a la vez.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lo he cambiado, ya no hay prioridad, es siempre el último que pasas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo reflejaria esta aclaracion en el changelog y en la docu del provider si tiene
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hecho