Skip to content

Add faint image of department logo behind class descriptions.#190

Open
SciDev5 wants to merge 5 commits into
sipb:mainfrom
SciDev5:main
Open

Add faint image of department logo behind class descriptions.#190
SciDev5 wants to merge 5 commits into
sipb:mainfrom
SciDev5:main

Conversation

@SciDev5

@SciDev5 SciDev5 commented May 28, 2025

Copy link
Copy Markdown
Contributor

Changes:

  • Image of department logo now appears behind the class description (blurred and faint in dark mode, just faint in light mode).
  • Class buttons now have a hover effect where they get slightly lighter.
    • Fixed issue with textColor where it would silently fail if an rgb(...) color is passed in (like that generated by the color picker on firefox).

image

@SuperSonicHub1

Copy link
Copy Markdown

Could you also include in the PR a preview of light mode?

@SuperSonicHub1

Copy link
Copy Markdown

We may want to optimize the SVGs using a tool like SVGO.

@SciDev5

SciDev5 commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

Here is light mode:
image

@SuperSonicHub1

Copy link
Copy Markdown

Would be great if we could squash 55aa4a8f into 012b787c as to not clog up commit history.

@SuperSonicHub1

Copy link
Copy Markdown

How should we handle courses we couldn't find logos for, if at all? The MIT seal might be a nice placeholder, seeing as especially in light mode this PR gives me watermark vibes, but that would require asking for permission in order to get the files.

@cjquines

Copy link
Copy Markdown
Member

i think it's cute but potentially annoying enough that we might need a way to configure this

@SciDev5

SciDev5 commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

I could add something in preferences alongside the color theme toggle.

@dtemkin1

Copy link
Copy Markdown
Collaborator

I think something in the preferences would be a good idea (+probably disabled if high contrast is needed?), let us know when it's ready for review!

@dtemkin1 dtemkin1 requested review from cjquines, dtemkin1 and psvenk May 30, 2025 01:58
@SciDev5

SciDev5 commented May 31, 2025

Copy link
Copy Markdown
Contributor Author

I have added a drop-down to the preferences. "Auto" is enabled in default color schemes and disabled in high-contrast color schemes.

image

@dtemkin1

dtemkin1 commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

@SciDev5 would you be able to rebase this on main? PR #187 implemented something similar to auto using null instead of it's own setting, which might also work for this

@cjquines

Copy link
Copy Markdown
Member

@SciDev5 bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants