Prevent cross-cluster resource access#1070
Open
mxsrc wants to merge 1 commit into
Open
Conversation
Currently, authentication and resource retrieval is decoupled, allowing API clients to authenticate to one cluster and access resources of a different one. This change introduces checks that resources are accessed in their correct scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, authentication and resource retrieval is decoupled, allowing API clients to authenticate to one cluster and access resources of a different one. This change introduces checks that resources are accessed in their correct scope.
Note that this fix was complicated by the fact that the backup API does not follow the cannonical API structure. In particular, the deletion of all LVol backups was registered at
/clusters/{cluster_id}/backups/{lvol_id}instead of/clusters/{cluster_id}/storage-pools/{pool_id}/volumes/{volume_id}/backups/. To correct for this, the PR duplicates the endpoint at the latter location and modifies the existing one to call the new function, which implicitly adds the ownership validation. The existing endpoint is marked as deprecated but will continue to function, maintaining compatibility.I confirmed that the linter and test failures predate this changeset.
Requesting a review from @noctarius specifically to confirm API modification.