Skip to content

refactor the towersit system#50

Open
blankochan wants to merge 5 commits into
mainfrom
blank/towersitv2
Open

refactor the towersit system#50
blankochan wants to merge 5 commits into
mainfrom
blank/towersitv2

Conversation

@blankochan

Copy link
Copy Markdown
Collaborator

something quick to note

this is gonna is currently broken on LabAPI and will be until this gets merged

goggles is also broken, if someone has goggles its gonna force them to take them off which causes all sorts of jank

@blankochan

Copy link
Copy Markdown
Collaborator Author

we need to fix CI at some point

@blankochan

Copy link
Copy Markdown
Collaborator Author

LabAPI pr is merged so everything should hopefully work when sl updates

@LumiFae

LumiFae commented Jun 27, 2025

Copy link
Copy Markdown
Member

Why is this draft?

@blankochan

Copy link
Copy Markdown
Collaborator Author

Because until labapi updates it's broken

@blankochan blankochan marked this pull request as ready for review June 28, 2025 20:56
@blankochan

blankochan commented Jun 28, 2025

Copy link
Copy Markdown
Collaborator Author

i decided to use a harmony patch so the file can just be deleted when LabAPI works

@blankochan

Copy link
Copy Markdown
Collaborator Author

also its still gonna be broken with players with goggles and it doesn't account for any effects a player might have

@blankochan

Copy link
Copy Markdown
Collaborator Author

I'm not entirely sure how to make the goggles drop instantly

@NotKeira

Copy link
Copy Markdown

What about getting players location prior to teleport and placing a googles there, then deleting the old goggles and undoing the effect from player

@NotKeira

Copy link
Copy Markdown

Not sure why you’d drop them if they’re in a sit tho doesn’t seem very beneficial

@blankochan

Copy link
Copy Markdown
Collaborator Author

So if you don't drop the items the garbage collector just entirely deletes the players shit if their inventory is cleared and there's no way to get it back without substantial work

Which is why we drop all the players items and then teleport them above the tutorial tower and freeze the physics

But player.DropAllItems plays the dropping animation if the player has goggles which is a nono

@LumiFae

LumiFae commented Jun 29, 2025

Copy link
Copy Markdown
Member

@blankochan Server.Host.AddItems() ? Just give the items to the server and save the references.

@blankochan

Copy link
Copy Markdown
Collaborator Author

Did not think about the fact that the server is technically a player, I'll play with that for a bit, but that might break really quickly if there is ever 2 players in a sit and there's more than 8 items across the two players

@LumiFae

LumiFae commented Jun 29, 2025

Copy link
Copy Markdown
Member

Item limit is checked before picking up the item, never after, so inventory won't be checked.

@blankochan

Copy link
Copy Markdown
Collaborator Author

not ready yet but i wanted to get it out before my tournament match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants