Skip to content

Complete removal of Paratext account linking#3968

Merged
pmachapman merged 1 commit into
masterfrom
fix/complete-pt-account-linking-removal
Jun 24, 2026
Merged

Complete removal of Paratext account linking#3968
pmachapman merged 1 commit into
masterfrom
fix/complete-pt-account-linking-removal

Conversation

@Nateowami

@Nateowami Nateowami commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

This finishes the work begun in #3938

I have marked it testing not required because I'm not aware of any non-contrived way to reach it, except a system admin joining a project (and therefore not having a Paratext role).

In fact, I think the message could be completely ripped out, but I'm not confident enough to do it just yet.

Screenshot from 2026-06-24 14-21-30 Screenshot from 2026-06-24 14-20-16

This change is Reviewable

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.95%. Comparing base (aaa62f2) to head (1500af1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ipture/ClientApp/src/xforge-common/auth.service.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3968      +/-   ##
==========================================
+ Coverage   80.92%   80.95%   +0.03%     
==========================================
  Files         637      638       +1     
  Lines       41249    41210      -39     
  Branches     6726     6715      -11     
==========================================
- Hits        33379    33362      -17     
+ Misses       6814     6797      -17     
+ Partials     1056     1051       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I have marked it testing not required because I'm not aware of any non-contrived way to reach it, except a system admin joining a project (and therefore not having a Paratext role).

I agree - I could only get a similar account be logging in with a Google account, then having a system admin manually modify that account to be a project admin.

I think your notice is appropriate for (what I imagine are accidental) cases like this, and perhaps any very old or corrupt user accounts that are not PT accounts but have admin access

@pmachapman reviewed 18 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@pmachapman pmachapman self-assigned this Jun 24, 2026
@pmachapman pmachapman merged commit cf90c98 into master Jun 24, 2026
38 checks passed
@pmachapman pmachapman deleted the fix/complete-pt-account-linking-removal branch June 24, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants