Skip to content

SF-3821 Switch to pnpm#3966

Open
pmachapman wants to merge 13 commits into
masterfrom
feature/SF-3821
Open

SF-3821 Switch to pnpm#3966
pmachapman wants to merge 13 commits into
masterfrom
feature/SF-3821

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Perform running locally, update to use pnpm:

Linux

cd ~/code/web-xforge
sudo npm install --global pnpm@11.9
find test src -name node_modules -print0 | xargs -0 rm -vrf
find test src -name obj -print0 | xargs -0 rm -vrf
dotnet clean
rm -Rf src/SIL.XForge/bin/
rm -Rf src/SIL.XForge.Scripture/bin/
rm -Rf test/SIL.XForge.Tests/bin/
rm -Rf test/SIL.XForge.Scripture.Tests/bin/
cd src/RealtimeServer && pnpm install && cd ../SIL.XForge.Scripture/ClientApp && pnpm install

Windows

Navigate to your Scripture Forge directory, then:

npm install --global pnpm@11.9
FOR /F "tokens=*" %G IN ('DIR /B /AD /S node_modules') DO RMDIR /S /Q "%G"
FOR /F "tokens=*" %G IN ('DIR /B /AD /S obj') DO RMDIR /S /Q "%G"
dotnet clean
rmdir /s src\SIL.XForge\bin
rmdir /s src\SIL.XForge.Scripture\bin
rmdir /s test\SIL.XForge.Tests\bin
rmdir /s test\SIL.XForge.Scripture.Tests\bin
cd src\RealtimeServer
pnpm install
cd ..\SIL.XForge.Scripture\ClientApp
pnpm install

When you move back to your previous branch, you should run:

Linux

cd ~/code/web-xforge
find test src -name node_modules -print0 | xargs -0 rm -vrf
find test src -name obj -print0 | xargs -0 rm -vrf
dotnet clean
rm -Rf src/SIL.XForge/bin/
rm -Rf src/SIL.XForge.Scripture/bin/
rm -Rf test/SIL.XForge.Tests/bin/
rm -Rf test/SIL.XForge.Scripture.Tests/bin/

Windows

FOR /F "tokens=*" %G IN ('DIR /B /AD /S node_modules') DO RMDIR /S /Q "%G"
FOR /F "tokens=*" %G IN ('DIR /B /AD /S obj') DO RMDIR /S /Q "%G"
dotnet clean
rmdir /s src\SIL.XForge\bin
rmdir /s src\SIL.XForge.Scripture\bin
rmdir /s test\SIL.XForge.Tests\bin
rmdir /s test\SIL.XForge.Scripture.Tests\bin

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jun 23, 2026
Comment thread .github/workflows/ci-lint-prettier.yml Fixed
Comment thread .github/workflows/ci-production-build.yml Fixed
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.90%. Comparing base (aaa62f2) to head (a2233b6).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ge/Realtime/RealtimeServiceCollectionExtensions.cs 0.00% 4 Missing ⚠️
src/SIL.XForge/Realtime/MemoryRealtimeService.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3966      +/-   ##
==========================================
- Coverage   80.92%   80.90%   -0.02%     
==========================================
  Files         637      637              
  Lines       41249    41255       +6     
  Branches     6726     6727       +1     
==========================================
  Hits        33379    33379              
- Misses       6814     6832      +18     
+ Partials     1056     1044      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman marked this pull request as draft June 23, 2026 23:51
Comment thread .github/workflows/ci-lint-prettier.yml Dismissed
Comment thread .github/workflows/ci-production-build.yml Dismissed
Comment thread .github/workflows/codeql.yml Dismissed
@pmachapman pmachapman force-pushed the feature/SF-3821 branch 2 times, most recently from 61225c8 to c54acaa Compare June 24, 2026 00:13
@github-advanced-security

Copy link
Copy Markdown
Contributor

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@pmachapman pmachapman force-pushed the feature/SF-3821 branch 3 times, most recently from faaff4f to 09a11ea Compare June 24, 2026 01:50
Comment thread .github/workflows/storybook-screenshots.yml Dismissed
@pmachapman pmachapman added the e2e Run e2e tests for this pull request label Jun 24, 2026
@pmachapman pmachapman marked this pull request as ready for review June 24, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants