serval-admin: link to Serval Builds rather than Draft Jobs#3962
Open
marksvc wants to merge 3 commits into
Open
serval-admin: link to Serval Builds rather than Draft Jobs#3962marksvc wants to merge 3 commits into
marksvc wants to merge 3 commits into
Conversation
On the Serval Administration - Projects tab, a button can be clicked to see the list of draft jobs. Similarly, on the Serval admin page for an indivdual project, a button can be clicked to view the list of draft jobs. This patch changes these places to go to the Serval Builds tab instead of the Draft Jobs tab, and adjusts the notices to say that the Draft Jobs tab is going away.
There was a problem hiding this comment.
Pull request overview
Updates Serval Administration navigation so “Draft Jobs” entry points route users to the newer Serval Builds tab, and shifts deprecation messaging toward the Draft Jobs tab being removed.
Changes:
- Updated navigation from project list and project detail to open the
serval-buildstab with a pre-filled search query (q=<projectId>). - Removed the “preview” notice from the Serval Builds tab.
- Added a warning notice to the Draft Jobs tab indicating it will be removed soon, plus spacing for notices.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-projects.component.ts |
Routes “Draft Jobs” action to Serval Builds tab using q search param. |
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-project.component.ts |
Routes project-level “View Draft Jobs” action to Serval Builds tab using q search param. |
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.html |
Removes the Serval Builds preview notice from the UI. |
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-jobs.component.scss |
Adds margins around notices in the Draft Jobs view. |
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-jobs.component.html |
Adds a warning notice about the Draft Jobs tab being deprecated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
3
| @if (isOnline) { | ||
| <div class="filter-controls"> | ||
| <app-date-range-picker [showReset]="true" (dateRangeChange)="onDateRangeChange($event)"></app-date-range-picker> |
Comment on lines
173
to
179
| viewDraftJobs(projectId: string): void { | ||
| void this.router.navigate(['/serval-administration'], { | ||
| queryParams: { | ||
| projectId, | ||
| tab: 'draft-jobs' | ||
| tab: 'serval-builds', | ||
| q: projectId | ||
| } | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
Right; that could be confusing. For now I chose to update just the UI labels of the buttons that link to the Serval Builds tab.
Comment on lines
347
to
353
| navigateToDraftJobs(): void { | ||
| void this.router.navigate(['/serval-administration'], { | ||
| queryParams: { | ||
| projectId: this.activatedProjectService.projectId!, | ||
| tab: 'draft-jobs' | ||
| tab: 'serval-builds', | ||
| q: this.activatedProjectService.projectId! | ||
| } | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
(I updated just the UI label for now.)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3962 +/- ##
=======================================
Coverage 80.92% 80.92%
=======================================
Files 637 637
Lines 41245 41245
Branches 6721 6702 -19
=======================================
Hits 33376 33376
- Misses 6814 6827 +13
+ Partials 1055 1042 -13 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Serval Administration - Projects tab, a button can be clicked
to see the list of draft jobs. Similarly, on the Serval admin page for
an indivdual project, a button can be clicked to view the list of
draft jobs.
This patch changes these places to go to the Serval Builds tab instead
of the Draft Jobs tab, and adjusts the notices to say that the Draft
Jobs tab is going away.
Opening a list of Serval Builds for a given project makes use of the Search feature. Screenshot showing Search control populated with a SF project ID:
The "Coming soon" notice on the Serval Builds tab is removed. A "Going away" notice is added to the Draft Jobs tab. Screenshot showing "Going away" notice:
Open in Devin Review
This change is