SF-3825 Allow parallel editor view even when a source isn't set by pmachapman · Pull Request #3952 · sillsdev/web-xforge

pmachapman · 2026-06-16T02:17:52Z

This PR adds an "always on" left hand tab pane, which when empty will show an "new tab" tab (I'm not sure on the wording/layout of this tab, so am really open to suggestions):

This change is

codecov · 2026-06-16T02:27:50Z

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.92%. Comparing base (e5df661) to head (946385b).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ntApp/src/app/translate/editor/editor.component.ts	76.19%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3952   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         637      637           
  Lines       41245    41259   +14     
  Branches     6721     6703   -18     
=======================================
+ Hits        33376    33390   +14     
- Misses       6814     6829   +15     
+ Partials     1055     1040   -15

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot

Pull request overview

Adds an “always on” left-hand tab pane in the translation editor so users can keep a parallel view even when no source project is configured, using a non-persisted “blank” tab as the empty-state UI.

Changes:

Introduces a new blank-tab editor tab type (non-closeable / non-movable / non-persisted) with i18n header + notice text.
Updates editor tab-state behavior to ensure an empty tab group shows the blank tab, and adjusts small-screen consolidation/deconsolidation behavior accordingly.
Simplifies editor layout logic by removing showSource-gated UI behavior and updating affected unit tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json	Adds English strings for the blank tab header and empty-state notice.
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/tabs/editor-tab-factory.service.ts	Adds factory support for creating the new `blank-tab` tab.
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts	Implements blank-tab add/remove logic; updates consolidation logic and tab placement behavior.
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts	Updates/removed tests that depended on `showSource` behavior.
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.scss	Adds styles for the blank tab notice container.
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.html	Always renders the two-pane tab layout and adds template content for `blank-tab`.
src/SIL.XForge.Scripture/ClientApp/src/app/shared/sf-tab-group/tab-state/tab-state.service.ts	Makes `deconsolidateTabGroups()` return a boolean indicating whether deconsolidation occurred.
src/RealtimeServer/scriptureforge/models/editor-tab.ts	Adds `blank-tab` to the shared tab-type model and exports `editorTabGroupTypes`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pmachapman · 2026-06-21T20:30:20Z

+          ? (this.tabState.getTabGroup(groupId)?.tabs ?? []).slice()
+          : tabs.filter(t => t.groupId === groupId);
+      if (groupTabs.length === 0 && blankTab == null) {
+        // Add the blank tab, if there are no tabs the tab group


pmachapman · 2026-06-21T20:30:20Z

+  private addBlankTab(tabs: FlatTabInfo<EditorTabGroupType, EditorTabInfo>[] | undefined = undefined): void {
+    for (const groupId of this.visibleTabGroups) {
+      // For each tab group (i.e. source and target)
+      const blankTab = this.tabState.getFirstTabOfTypeIndex('blank-tab', groupId);
+      const groupTabs: EditorTabInfo[] =


RaymondLuong3

I am getting an error at runtime. I am only able to test this behaviour if I hardcode values for editorTabGroupTypes.

It seems to me that is should be the responsibility of the tab group component to show the empty state instead of the host components to generate empty pages. Is this feasible?

@RaymondLuong3 reviewed 8 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on pmachapman).

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts line 1454 at r1 (raw file):

          : tabs.filter(t => t.groupId === groupId);
      if (groupTabs.length === 0 && blankTab == null) {
        // Add the blank tab, if there are no tabs the tab group

Nit: That should say 'if there are no tabs in the tab group'

Code quote:

 // Add the blank tab, if there are no tabs the tab group

pmachapman

I am getting an error at runtime. I am only able to test this behavior if I hardcode values for editorTabGroupTypes.

Did you run npm run build in the real time server, or build the dotnet app (which should do this)? This error is because the real time server library is not up-to-date in your dependencies.

It seems to me that is should be the responsibility of the tab group component to show the empty state instead of the host components to generate empty pages. Is this feasible?

I originally went down this path, but it required a heavy rearchitecting of the tab components in both the SCSS and TypeScript to get it to function (and I still didn't get it working perfectly). On closer inspection of the code, the tab components are already designed to have tabs that are saved to the database, and tabs that are not; so I went with creating a tab this is not saved to the database.

@pmachapman made 6 comments and resolved 5 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts line 1454 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Nit: That should say 'if there are no tabs in the tab group'

Done.

pmachapman · 2026-06-21T20:30:20Z

+  private addBlankTab(tabs: FlatTabInfo<EditorTabGroupType, EditorTabInfo>[] | undefined = undefined): void {
+    for (const groupId of this.visibleTabGroups) {
+      // For each tab group (i.e. source and target)
+      const blankTab = this.tabState.getFirstTabOfTypeIndex('blank-tab', groupId);
+      const groupTabs: EditorTabInfo[] =


pmachapman · 2026-06-21T20:30:20Z

+          ? (this.tabState.getTabGroup(groupId)?.tabs ?? []).slice()
+          : tabs.filter(t => t.groupId === groupId);
+      if (groupTabs.length === 0 && blankTab == null) {
+        // Add the blank tab, if there are no tabs the tab group


RaymondLuong3

This looks good to me. Thanks for the context of why this is being handled by the host component over the tab-state service. Just noting that his will mean even resources will have the blank tab page visible, but I think that is perfectly reasonable.

@RaymondLuong3 reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

pmachapman temporarily deployed to screenshot_diff June 16, 2026 02:24 — with GitHub Actions Inactive

pmachapman marked this pull request as ready for review June 16, 2026 02:30

pmachapman added will require testing PR should not be merged until testers confirm testing is complete e2e Run e2e tests for this pull request labels Jun 16, 2026

pmachapman temporarily deployed to e2e_tests June 16, 2026 02:39 — with GitHub Actions Inactive

pmachapman removed the e2e Run e2e tests for this pull request label Jun 16, 2026

RaymondLuong3 self-assigned this Jun 18, 2026

RaymondLuong3 requested a review from Copilot June 18, 2026 19:26

Copilot started reviewing on behalf of RaymondLuong3 June 18, 2026 19:26 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

RaymondLuong3 requested changes Jun 18, 2026

View reviewed changes

SF-3825 Allow parallel editor view even when a source isn't set

946385b

pmachapman force-pushed the fix/SF-3825 branch from 4a4dea2 to 946385b Compare June 21, 2026 20:30

pmachapman commented Jun 21, 2026

View reviewed changes

pmachapman temporarily deployed to screenshot_diff June 21, 2026 20:36 — with GitHub Actions Inactive

RaymondLuong3 approved these changes Jun 23, 2026

View reviewed changes

RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jun 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

SF-3825 Allow parallel editor view even when a source isn't set#3952

SF-3825 Allow parallel editor view even when a source isn't set#3952
pmachapman wants to merge 1 commit into
masterfrom
fix/SF-3825

pmachapman commented Jun 16, 2026 •

edited by irahopkinson

Loading

Uh oh!

codecov Bot commented Jun 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

pmachapman Jun 21, 2026

Uh oh!

Uh oh!

pmachapman Jun 21, 2026

Uh oh!

RaymondLuong3 left a comment

Uh oh!

pmachapman left a comment

Uh oh!

Uh oh!

Uh oh!

pmachapman Jun 21, 2026

Uh oh!

pmachapman Jun 21, 2026

Uh oh!

RaymondLuong3 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

pmachapman commented Jun 16, 2026 • edited by irahopkinson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

pmachapman Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pmachapman Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

RaymondLuong3 left a comment

Choose a reason for hiding this comment

Uh oh!

pmachapman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pmachapman Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

pmachapman Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

RaymondLuong3 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pmachapman commented Jun 16, 2026 •

edited by irahopkinson

Loading

codecov Bot commented Jun 16, 2026 •

edited

Loading