OCP Upgrade: Add missing openshift_build_name to upgrade job definitions#26
Merged
Merged
Conversation
Change-Id: I53f1e8714ab600523eff948b8ee86d332a653c3c
dlaw4608
requested review from
chenwng,
ekuris-redhat,
eshulman2,
gryf,
imatza-rh,
mandre,
stephenfin,
tusharjadhav3302 and
winiciusallan
as code owners
July 23, 2026 10:26
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekuris-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| # Target version for upgrade stage | ||
| upgrade_target_version: "4.21" | ||
| upgrade_channel: candidate | ||
| openshift_build_name: "" |
Contributor
There was a problem hiding this comment.
we could add the comment "# It can be an empty value "" (latest nightly), a given build
" similar to other job defs for future readers. Not a blocker at all .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
openshift_build_name: ""to all upgrade job definitions to fix build resolution during the upgrade stageVerified 4.21 → 4.22 upgrade completes successfully on RHOSO 18 with this field present
Next step is adding a job definiton for upgrade_4.21_to_4.22_osp18.yaml in ci-framework
Then E2E validation can be ran.
But this PR needs to be merged first