Skip to content

OCP Upgrade: Add missing openshift_build_name to upgrade job definitions#26

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
ocp_upgrade_job_def
Jul 23, 2026
Merged

OCP Upgrade: Add missing openshift_build_name to upgrade job definitions#26
openshift-merge-bot[bot] merged 1 commit into
mainfrom
ocp_upgrade_job_def

Conversation

@dlaw4608

Copy link
Copy Markdown
Contributor

Add openshift_build_name: "" to all upgrade job definitions to fix build resolution during the upgrade stage

Verified 4.21 → 4.22 upgrade completes successfully on RHOSO 18 with this field present

TASK [shiftstack.stages.upgrade : Display upgrade completion] ******************
ok: [localhost] => {
    "msg": "Successfully upgraded cluster from 4.21 to 4.22"
}

Next step is adding a job definiton for upgrade_4.21_to_4.22_osp18.yaml in ci-framework
Then E2E validation can be ran.

But this PR needs to be merged first

Change-Id: I53f1e8714ab600523eff948b8ee86d332a653c3c

@ekuris-redhat ekuris-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgrm
/approve

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekuris-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit fbc3536 into main Jul 23, 2026
2 checks passed
# Target version for upgrade stage
upgrade_target_version: "4.21"
upgrade_channel: candidate
openshift_build_name: ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add the comment "# It can be an empty value "" (latest nightly), a given build
" similar to other job defs for future readers. Not a blocker at all .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ready-for-review PR is ready for code review

Development

Successfully merging this pull request may close these issues.

3 participants