Fix duplicate-heading ToC jumps in the editor - #335
Merged
PathGao merged 1 commit intoAug 2, 2026
Conversation
Collaborator
Author
|
@alecdotdev This is the next linear child after #333. It addresses the reporter’s remaining #202 reproduction: preview jumps already use the deduplicated id, while editor jumps were still text searches from line 1. The editor now receives the clicked heading’s source line; a missing source position retains the text-search fallback. |
PathGao
force-pushed
the
fix/toc-editor-source-position
branch
from
August 2, 2026 04:03
43333fd to
01ceedb
Compare
PathGao
force-pushed
the
fix/toc-editor-source-position
branch
from
August 2, 2026 06:38
01ceedb to
93cf159
Compare
PathGao
marked this pull request as ready for review
August 2, 2026 06:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202.
The preview already jumps by the deduplicated heading id. The editor path still searched by heading text from line 1, so selecting a duplicate title always focused the first heading.
This change passes the clicked preview heading’s
data-sourceposstart line through the ToC callback and reveals that exact Monaco line. Text matching remains only as a fallback when a source position is unavailable.Validation:
npm cinpm run checknpm test(153 passing)cargo test --manifest-path src-tauri/Cargo.toml(27 passing)Depends on #333. Merge after the existing linear chain.