Skip to content

fix: delimit parenthesized autolinks - #291

Merged
alecdotdev merged 2 commits into
sftwrdotdev:masterfrom
PathGao:fix/markdown-parenthesized-autolink
Aug 2, 2026
Merged

fix: delimit parenthesized autolinks#291
alecdotdev merged 2 commits into
sftwrdotdev:masterfrom
PathGao:fix/markdown-parenthesized-autolink

Conversation

@PathGao

@PathGao PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Fixes #290

Parenthesized bare URLs followed immediately by text are rendered as explicit Markdown links, so the closing parenthesis and following text stay outside the URL.

Includes a Rust regression test for the reported Speedtest URL.

Depends on #286 because upstream master currently has the toolbar-test regression fixed there; merge #286 first.

@PathGao

PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

@alecdotdev This is ready for review after #286. It adds a regression test and keeps the closing parenthesis plus adjacent text out of the bare URL.

@PathGao

PathGao commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@alecdotdev GitHub recently introduced Stacked Pull Requests in private preview: https://github.github.com/gh-stack/

I have several follow-up PRs with genuine commit ancestry. Today they all target master, so later PRs carry earlier changes in their diff; some also appear to conflict until their predecessors land. If you are open to it, could you enable the preview for this repository? It would let us model only the real dependency chains, give each layer a focused diff, and merge a reviewed chain in order.

I would not convert unrelated PRs into one long stack; I would use it only for small, clearly dependent sequences. If you prefer the current workflow, I will continue to rebase and submit each PR independently.

@alecdotdev

Copy link
Copy Markdown
Collaborator

@PathGao I've been looking forward to stacked PRs. I'll need to transfer the repo to an organization so I'll look into transferring that asap.

@PathGao

PathGao commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@alecdotdev #291 is now clean and ready to merge.

I have also rebased my open PRs from #310 onward onto the current master and resolved their merge conflicts; their fresh CI runs are now updating.

When you have time, could you please share maintainer direction on #209, #230, and #281? The decisions there affect the macOS release/signing path, embedded-video handling, and application-menu/settings work that I plan to take on next. Thank you.

@alecdotdev

Copy link
Copy Markdown
Collaborator

@PathGao transferred to org, according to GitHub, stacked PRs should now work. not sure if the gh stack cli feature is required as it looks like it can also be used in GitHub Web? let me know if it gives you access to stacks now

@alecdotdev
alecdotdev merged commit 3e63d9a into sftwrdotdev:master Aug 2, 2026
5 checks passed
@PathGao
PathGao deleted the fix/markdown-parenthesized-autolink branch August 2, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL inside parentheses is parsed incorrectly when text immediately follows the closing parenthesis

2 participants