feat(serverpod_logging): Add isolate-backed IsolatedLogWriter#123
Conversation
|
Warning Review limit reached
More reviews will be available in 27 minutes and 22 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nielsenko
force-pushed
the
feat-isolated-logger
branch
5 times, most recently
from
f2d3880 to
51170c0
Compare
nielsenko
force-pushed
the
feat-isolated-logger
branch
from
51170c0 to
b315cea
Compare
- progress_nesting_test: a log emitted inside a progress runner must be attributed to the progress scope via the Zone, and a nested progress must child under the outer scope. - progress_relabel_test: progress must never surface the runner's result as a scope label (uses a generic recording writer, no terminal rendering).
These fail to compile if the runner is narrowed to Future<T> Function()
nielsenko
force-pushed
the
feat-isolated-logger
branch
2 times, most recently
from
f0f2c2f to
d6bb994
Compare
Framework-level tests (no CLI rendering): - Level gating skips the entry factory below the threshold - Runtime logLevel changes take effect; isDebugEnabled tracks it - Writer errors are swallowed (dispatch is best-effort) - Writes serialize in invocation order even when earlier ones are slower - close() drops any further dispatches - Convenience methods map to the right level; error() attaches error + stack trace - Logs emitted outside any progress attach to the synthetic root scope - progress passes metadata through to the opened scope - LogScope parent/child: root has no parent; a child keeps its own id/label/metadata
nielsenko
force-pushed
the
feat-isolated-logger
branch
from
d6bb994 to
09d5400
Compare
A LogWriter that runs any wrapped writer on a dedicated isolate (via IsolatedObject), so timer-driven spinners keep animating even when the calling isolate is blocked.
nielsenko
force-pushed
the
feat-isolated-logger
branch
from
09d5400 to
74ec856
Compare
3 participants
Add
IsolatedLogWriter