[codex] Trigger GCP lab from maintainer label#52
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb0575cb98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| github.event_name == 'pull_request_target' && | ||
| github.event.action == 'labeled' && | ||
| github.event.label.name == 'run-gcp-lab' |
There was a problem hiding this comment.
Restrict the label trigger to trusted maintainers
When this workflow is enabled on repos that grant non-maintainers triage access, this condition lets them trigger the GCP lab just by applying run-gcp-lab—GitHub documents that anyone with triage access can apply labels. That label path has id-token: write and eventually scripts/lab/gcp/run-smoke.sh clones and executes the PR head on a GCP VM, so the approval/maintainer association check used for pull_request_review should also be enforced here or verified through the API before starting cloud resources.
Useful? React with 👍 / 👎.
Summary
pull_request_targetlabel trigger forrun-gcp-labValidation
./scripts/check.shgit diff --checkNotes
This is the follow-up for the skipped/action-required approved-review run on PR #51. After this lands, maintainers can apply
run-gcp-labto an approved public PR to trigger the disposable GCP emulator lab.