Skip to content

Fix ADB transport helper regressions#127

Draft
adamcohenhillel wants to merge 1 commit into
feat/adb-more-toolsfrom
codex/fix-adb-more-tools-runtime-helpers
Draft

Fix ADB transport helper regressions#127
adamcohenhillel wants to merge 1 commit into
feat/adb-more-toolsfrom
codex/fix-adb-more-tools-runtime-helpers

Conversation

@adamcohenhillel

Copy link
Copy Markdown
Contributor

Summary

  • define the helper methods used by the new ADB read-only and element-targeted commands
  • sync the CLI and MCP packaged ADB transport mirrors
  • add contract coverage for read-only command execution and element action resolution

Evidence

  • origin/feat/adb-more-tools commit de21b27adfabb6095c42b2fdf1ebf33ad9b2ac99 changed integrations/adb/openphone-adb-transport.mjs only, while the package mirrors still differed
  • ./scripts/check.sh failed in tests/integrations/runtime-package-contract.mjs because packaged ADB transports did not match the shared source
  • direct fake-transport execution failed with ReferenceError for parseInteractiveElements, parseBatteryDump, and unsupportedOnDeviceState

Validation

  • node tests/integrations/adb-stateful-gating-contract.mjs
  • node tests/integrations/runtime-package-contract.mjs
  • npm test in integrations/cli
  • npm test in integrations/mcp-server
  • ./scripts/check.sh
  • git diff --check

No device eval was run: adb devices returned no attached devices.

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openphone-docs Ready Ready Preview, Comment Jul 7, 2026 4:06am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant