Fix MCP 2025-11-25 negotiation#123
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
adamcohenhillel
force-pushed
the
codex/fix-mcp-2025-11-25
branch
from
2282cd4 to
fa7e70b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2025-11-25as a supported MCP protocol version, newest-first.2025-06-18support so older clients are still echoed duringinitialize.Bug evidence
2026-07-04T04:01:56Zfound one merged PR onmain: Fix MCP stdio framing and negotiate protocolVersion #120, merge commit5b25b3b5add0e5aba339e471942c2f5461a590d4.integrations/mcp-server/src/index.mjsfrom advertising2025-11-25to only supporting2025-06-18.integrations/mcp-server/src/index.mjs:11warning that clients advertising2025-11-25will receive2025-06-18and should disconnect.2025-11-25says servers must echo the requested protocol version when supported, otherwise respond with another supported version.Validation
npm testinintegrations/mcp-server./scripts/check.shgit diff --check2025-11-25,2025-06-18, parse-error recovery, andpingNotes
shellcheckis not installed locally;./scripts/check.shreported it skipped shellcheck and ranbash -ncoverage instead.codexorcodex-automationlabels are available in this repository.