Add a reproducible benchmark script and caveat the perf snapshot#282
Merged
Conversation
The README's performance snapshot listed specific figures (0.7 ms spawn, 70 us round-trip, ...) with no backing benchmark -- test_performance.py is only a <5s smoke test. For a project that markets honesty about being a prototype, unbacked numbers are a credibility gap. - scripts/benchmark.py measures spawn latency and cell round-trip on the current host (mean/median/p95) for the subinterpreter and process backends. - README reframes the table as indicative, hardware-dependent reference figures and points at the script to reproduce them; it flags that the encrypted- throughput and RSS rows are not yet covered by the script. New smoke test locks the script's importability and its statistics helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PbbJc7Ntj159D9LNGevwC2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README's Performance snapshot listed specific figures (0.7 ms spawn, 70 µs round-trip, 1.9 M msgs/core, 0.5 MiB RSS) with no backing benchmark —
test_performance.pyis only a<5 ssmoke test. For a project that markets honesty about being a prototype, unbacked headline numbers are a credibility gap.Changes
scripts/benchmark.py— measures spawn latency and cell round-trip on the current host (mean/median/p95), for--backend subinterpreter(default) and--backend process.Tests
New smoke test locks the script's importability and its pure statistics helper so it doesn't silently bit-rot. (The spawn/round-trip timing itself is exercised by the existing performance tests.)
Found during a full-project review.
🤖 Generated with Claude Code
Generated by Claude Code