Conversation
The binding and the sample sat at the repository root while the tests were already under tests/, and Nugets/ had been reduced to a single icon.png by the move from .nuspec files to dotnet pack. src/FFmpegKit.Android/ was FFmpegKit.Android/ samples/FFmpegKit.Android.Example/ was FFmpegKit.Android.Example/ src/FFmpegKit.Android/icon.png was Nugets/icon.png The icon moves into the project that packs it, which removes a ../ hop rather than adding one, and Nugets/ is gone. FetchJars.sh now stages downloads in a temporary directory and moves them into place only once every file has arrived. It used to delete the existing .aar and .jar files first, so a version that turned out not to exist left the working copy with no binaries at all and a 200 MB re-download to recover - which is exactly what happened while verifying this change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binding and the sample sat at the repository root while the tests were already under tests/, and Nugets/ had been reduced to a single icon.png by the move from .nuspec files to dotnet pack.
src/FFmpegKit.Android/ was FFmpegKit.Android/
samples/FFmpegKit.Android.Example/ was FFmpegKit.Android.Example/
src/FFmpegKit.Android/icon.png was Nugets/icon.png
The icon moves into the project that packs it, which removes a ../ hop rather than adding one, and Nugets/ is gone.
FetchJars.sh now stages downloads in a temporary directory and moves them into place only once every file has arrived. It used to delete the existing .aar and .jar files first, so a version that turned out not to exist left the working copy with no binaries at all and a 200 MB re-download to recover - which is exactly what happened while verifying this change.