Add redirect encodings and robust cleanup for processes#63
Add redirect encodings and robust cleanup for processes#63google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Added `StandardErrorEncoding` and `StandardOutputEncoding` set to UTF-8 for all process starts in `cli/Program.cs`. - Implemented `try-finally` blocks for process management in `EnsureEnvironment` and `RunDotnetAsync`. - Added robust cleanup logic: wait 310ms if not exited, kill process tree, wait 310ms again, and throw exception if still not exited. - Ensured `Dispose()` is always called and handled unstarted processes to avoid masking startup errors.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change ensures that all external processes started by the FUnit CLI use UTF-8 encoding for redirected output and error streams. It also introduces a more reliable process termination sequence to prevent orphaned processes and ensure proper resource cleanup, even in case of failures. I've addressed code review feedback by ensuring
Dispose()is called in a nestedfinallyblock and by tracking if a process was actually started before accessing its properties in the cleanup logic.PR created automatically by Jules for task 15566421418383895561 started by @sator-imaging