Add Vec::push_mut#670
Open
mdrssv wants to merge 1 commit into
Open
Conversation
sgued
requested changes
Jul 16, 2026
sgued
requested changes
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Thanks for the contribution! This looks useful.
Some of the clippy lints failure are caused by existing code and the update to 1.97 and have been fixed in #671 so please rebase on top of master. There are still a couple of lints that affect your code though.
zeenix
requested changes
Jul 16, 2026
zeenix
left a comment
zeenix
left a comment
Contributor
There was a problem hiding this comment.
I left a comment with 2 changes requested.
mdrssv
force-pushed
the
push-mut
branch
2 times, most recently
from
July 16, 2026 11:56
73480ce to
f08dcc5
Compare
Author
|
Thanks for the feedback |
mdrssv
force-pushed
the
push-mut
branch
2 times, most recently
from
July 16, 2026 12:00
75fdb90 to
0ff8b28
Compare
zeenix
reviewed
Jul 16, 2026
mdrssv
force-pushed
the
push-mut
branch
2 times, most recently
from
July 17, 2026 10:12
3a68dfb to
357cde6
Compare
zeenix
reviewed
Jul 17, 2026
Comment on lines
+703
to
+706
| // Safety: len has been checked to be less then capacity, enough for one more item | ||
| unsafe { self.push_unchecked(item) }; | ||
| // Safety: len which was obtained before insertion now corresponds to self.len() - 1 | ||
| // representing the index for the just added item |
Contributor
There was a problem hiding this comment.
Comments here are still missing their .. :)
Contributor
There was a problem hiding this comment.
A final thouch and we can merge it, thanks!
sgued
reviewed
Jul 17, 2026
| pub fn push_mut(&mut self, item: T) -> Result<&mut T, T> { | ||
| let len = self.len(); | ||
| if len < self.capacity() { | ||
| // Safety: len has been checked to be less then capacity, enough for one more item |
Contributor
There was a problem hiding this comment.
A little typo
Suggested change
| // Safety: len has been checked to be less then capacity, enough for one more item | |
| // Safety: len has been checked to be less than capacity, enough for one more item |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors: std::vec::Vec::push_mut into heapless