fix: allow parsing Descriptor<DescriptorPublicKey> from pk with xprv#970
Draft
trevarj wants to merge 1 commit into
Draft
fix: allow parsing Descriptor<DescriptorPublicKey> from pk with xprv#970trevarj wants to merge 1 commit into
trevarj wants to merge 1 commit into
Conversation
Refactor and fix FromStr for DescriptorPublicKey so that it can parse a xprv/tprv by doing the conversion into the DescriptorPublicKey. Added test that reflects what was reported in the issues: bitcoinfuzz/bitcoinfuzz#70 rust-bitcoin#785
Member
|
This feels a little dangerous to me. If the user provides secret data and then we irreversibly throw it away, could that cause a loss of the secret? |
Contributor
Author
Yeah, that's a good point. Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and fix FromStr for DescriptorPublicKey so that it can parse a
xprv/tprv by doing the conversion into the DescriptorPublicKey.
Added test that reflects what was reported in the issues:
bitcoinfuzz/bitcoinfuzz#70
#785