fix(0026): re-add enrichment-worker to the cargo workspace#63
Merged
Conversation
The crate was dropped from the root Cargo.toml `members` list by a later merge that rewrote the block, so since the prototype commit it was excluded from `cargo check/test --workspace` — silently un-built and un-tested by CI. Re-add the member so the crate (and its 24 unit + 2 e2e tests) is covered again; the live-CH integration tests stay `#[ignore]`d so CI compiles but skips them. Also collapse a nested `if let` in ch_enrich.rs to clear the only clippy warning (behaviour unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/enrichment-workerto the rootCargo.tomlworkspacemembers. It had been dropped when a later merge rewrote themembersblock (for the 0039/0054 crates), silently excluding the crate fromcargo check/test --workspace— un-built and un-tested by CI since the prototype commit.if letinch_enrich.rsto clear the only clippy warning (behaviour unchanged).cargo check --workspace+ clippy + fmt clean; 24 unit + 2 e2e tests pass; all 3#[ignore]d live-CH integration tests pass against a local ClickHouse pinned to the prod version 26.3.10.60 (oracle/peg/pivot tiers, idempotency, oracle-miss-stays-zero, budget-defer, watermark bound). The integration tests stay#[ignore]d so CI compiles but skips them (no CH on the runner).active.