Fix/approval workflow persistence#794
Open
MerlinTheWhiz wants to merge 5 commits into
Open
Conversation
|
@MerlinTheWhiz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict. |
Contributor
Author
|
@RUKAYAT-CODER Very sorry for the delay. I stepped out to touch grass today. I'll get on it soon. |
e728b65 to
e217d3c
Compare
e217d3c to
ab1cbf8
Compare
Contributor
Author
|
@RUKAYAT-CODER I've resolved conflicts. You can merge review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The approval workflow previously relied on a module-level
Mapas its data store, causing all submissions to be lost on every server restart or cold start. This made the workflow unreliable in production with autoscaling or periodic restarts.Changes made:
content_approvalstable migration with UUID primary key, proper CHECK constraints oncontent_typeandstatus,TIMESTAMPTZtimestamps, and indexes onstatus,submitted_by, andsubmitted_atMapCRUD operations in the route handler with parameterized SQL queriesedgetonodejs(required by thepgdatabase client)gen_random_uuid()instead of the ad-hocapproval-${Date.now()}-${Math.random()...}patternApprovalItemcamelCase interface, so the API response shape remains unchangedRelated Issue
Closes #774
Type of Change
Checklist