Skip to content

docs(solutions): add Payment Service Providers page#346

Open
jmaier6 wants to merge 1 commit into
mainfrom
docs/psp-solutions-page
Open

docs(solutions): add Payment Service Providers page#346
jmaier6 wants to merge 1 commit into
mainfrom
docs/psp-solutions-page

Conversation

@jmaier6

@jmaier6 jmaier6 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

New PSP solutions page (pay-ins/commerce, disbursements, compliance screening, features, pricing), modeled on the commerce-and-payments page and wired into the Solutions nav.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Claude finished @jmaier6's task in 1m 22s —— View job


Code Review: PSP Solutions page

  • Read new page + docs.json change
  • Compare against exemplar (commerce-and-payments) and AGENTS.md conventions
  • Verify all internal links resolve
  • Check terminology / style compliance
  • Post review

Solid page. It pattern-matches the commerce-and-payments exemplar well, the frontmatter is correct, and all 14 internal links resolve to real files. solutions/ is explicitly out of scope for the v1 style guide (AGENTS.md §1.1), so the bar here is "match the neighbors" — which it does. The docs.json nav wiring is correct (added right after commerce-and-payments in the Solutions group).

A few small things:

🐛 Typo

  • payment-service-providers.mdx:48 — "more genreally" → "generally".
    Fix this →

🧹 Nits (cosmetic, optional)

  • Trailing whitespace on lines 30, 32, and 48.
  • Double blank lines at 7–8, 63–64, and 68–69. The exemplar uses single blank lines between sections.
  • Line 36: "creator and worker disbursements, and cross-border payout" — reads better as "payouts" to match the surrounding plurals.

💅 Style — all good

  • Terminology is compliant: cross-chain hyphenated, onchain one word, USDC caps without backticks in prose, requestId / expandedPriceImpact backticked as code values (AGENTS.md §5, §2.9).
  • Heading hierarchy is clean (##/### only, no #), paragraphs stay short, and the <Columns>/<Card> hero matches the exemplar.

💭 One thing to confirm (non-blocking)

This page overlaps substantially with commerce-and-payments.mdx (same hero stats, same pay-in/deposit-address framing, overlapping feature list). The PR description says that's intentional — modeling on the commerce page for a distinct PSP audience. Just flagging for the author/reviewer to confirm the two are meant to coexist rather than one superseding the other, since readers landing on either may not realize the other exists. No cross-link between them currently.

Nothing here is blocking. The typo is the only thing I'd fix before merge.

@jmaier6 jmaier6 requested a review from coco306 June 26, 2026 23:20
@mintlify

mintlify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟢 Ready View Preview Jun 26, 2026, 11:23 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants