fix(#3482): resolve SonarQube MINOR issues in homepage workspace#3498
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3482): resolve SonarQube MINOR issues in homepage workspace#3498fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Fix two SonarQube issues in the dynamic-home-page plugin: - S4325 (useHomePageCardTitle.ts): Remove unnecessary type assertion `as keyof typeof t` which resolved to function object keys (string | number | symbol), not translation keys. Replaced direct `t()` call with existing `getTranslatedTextWithFallback` helper that handles the type assertion internally. - S7735 (OnboardingSection.tsx): Replace negated ternary condition `!profileLoading ? <jsx> : null` with the positive form `profileLoading ? null : <jsx>`. Closes #3482
fullsend-ai-coder
Bot
requested review from
a team,
Eswaraiahsapram and
christoph-jerolimov
as code owners
Contributor
|
This pull request adds a new top-level directory under |
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3498 +/- ##
=======================================
Coverage 53.61% 53.61%
=======================================
Files 2254 2254
Lines 85821 85820 -1
Branches 24157 24156 -1
=======================================
Hits 46014 46014
+ Misses 39628 39627 -1
Partials 179 179
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two SonarQube issues in the dynamic-home-page plugin:
assertion
as keyof typeof twhich resolved to functionobject keys (string | number | symbol), not translation
keys. Replaced direct
t()call with existinggetTranslatedTextWithFallbackhelper that handlesthe type assertion internally.
condition
!profileLoading ? <jsx> : nullwith thepositive form
profileLoading ? null : <jsx>.Closes #3482
Post-script verification
agent/3482-fix-sonarqube-homepage)44cd732f48f582229e5c6706d597075a90dcbcb3..HEAD)