Avoid rc package deep imports#1489
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough该 PR 将所有对 Changes模块导入重构和依赖优化
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/index.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request primarily refactors imports to use the root @rc-component/util package instead of deep links, updates dependencies by replacing rc-animate with @rc-component/motion, and expands the public API by exporting additional types and the convertChildrenToColumns utility. Review feedback suggests consolidating the CompareProps type definition by exporting it from Table.tsx and importing it in VirtualTable/index.tsx to avoid duplication and improve consistency across the package.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
- Coverage 96.12% 96.10% -0.02%
==========================================
Files 57 57
Lines 3456 3442 -14
Branches 639 639
==========================================
- Hits 3322 3308 -14
Misses 129 129
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Refs ant-design/ant-design#58115 antd 侧统一跟踪 rc 包 es/lib 深路径引用问题。 |
背景
为配合 rc 包统一避免引用其他 rc 包的
es/lib构建产物内部路径,本次将 table 中相关引用调整为从包根入口导入公开 API。调整内容
@rc-component/father-plugin和@rc-component/util@rc-component/context、@rc-component/resize-observer、@rc-component/util、@rc-component/virtual-list等深路径引用改为根入口引用lib路径引用验证
npm run lint通过,存在既有 warning,无 errorSummary by CodeRabbit
New Features
Chores