RDKEMW-22160: Order service start after PowerManager - #330
Open
Anand73-n wants to merge 1 commit into
Open
Conversation
Reason for change: Ensure PowerManager service is started before NetworkManager Test procedure: Reboot, then inspect the order units actually started Risks: low Priority: P1 Signed-off-by: Anand N <Anand_N@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures NetworkManager is started after the PowerManager service by adding a systemd drop-in for the NetworkManager unit (and includes a small logging tweak in the PowerManager client).
Changes:
- Add a systemd drop-in to order
wpeframework-networkmanager.serviceafterwpeframework-powermanager.service. - Install the new drop-in via the plugin CMake install rules.
- Adjust constructor logging in
NetworkManagerPowerClient.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugin/NetworkManagerPowerClient.cpp | Updates constructor INFO logs around PowerManager connection setup. |
| plugin/gnome/systemd/nm-powermanager.conf | Adds systemd drop-in intended to order NetworkManager after PowerManager. |
| plugin/CMakeLists.txt | Installs the new systemd drop-in into wpeframework-networkmanager.service.d. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+3
| [Unit] | ||
| # Ensure NetworkManager starts after PowerManager | ||
| After=wpeframework-powermanager.service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Ensure PowerManager service is started before NetworkManager
Test procedure: Reboot, then inspect the order units actually started
Risks: low
Priority: P1