RDKEMW-21821: Order service start after PowerManager - #329
Open
Anand73-n wants to merge 1 commit into
Open
Conversation
Reason for change: Ensure PowerManager service is started before NetworkManager Test procedure: Reboot, then inspect the order units actually started Risks: low Priority: P1 Signed-off-by: Anand N <Anand_N@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures wpeframework-networkmanager is ordered to start after the PowerManager service on GNOME/systemd-based deployments, aligning NetworkManager startup sequencing with PowerManager availability.
Changes:
- Add a systemd drop-in to order NetworkManager after
wpeframework-powermanager.service. - Install the new drop-in into
wpeframework-networkmanager.service.dvia CMake. - Adjust constructor logging in
NetworkManagerPowerClient.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugin/NetworkManagerPowerClient.cpp | Updates constructor logging around the PowerManager RPC Open call. |
| plugin/gnome/systemd/nm-powermanager.conf | Adds a systemd drop-in to order NetworkManager after PowerManager. |
| plugin/CMakeLists.txt | Installs the new systemd drop-in into the NetworkManager service override directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
karuna2git
reviewed
Jul 29, 2026
karuna2git
left a comment
karuna2git
left a comment
Contributor
There was a problem hiding this comment.
approved. Let LRM merges if there is hotpatch release for 8.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Ensure PowerManager service is started before NetworkManager
Test procedure: Reboot, then inspect the order units actually started
Risks: low
Priority: P1